Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Mar 24, 2025

Let's give this a try in our docs project to see how well it works. Happy to close if anyone has concerns regarding sessionStorage usage but we already use Replay in docs, so we already write and read from it. With this change, we can link to a previous trace even if users hard-navigate or hard-reload the page.

@vercel
Copy link

vercel bot commented Mar 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 5:08pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 5:08pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Mar 24, 2025 5:08pm

@Lms24 Lms24 self-assigned this Mar 24, 2025
@Lms24 Lms24 requested review from chargome and s1gr1d March 24, 2025 16:20
@codecov
Copy link

codecov bot commented Mar 24, 2025

Bundle Report

Changes will increase total bundle size by 3.27kB (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.68MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.98MB 3.28kB (0.03%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js 48 bytes 893.85kB 0.01%
static/chunks/3782-*.js (New) 374.43kB 374.43kB 100.0% 🚀
server/app/sitemap.xml/route_client-*.js 3 bytes 255.13kB 0.0%
server/app/robots.txt/route_client-*.js 3 bytes 255.13kB 0.0%
server/app/_not-*.js 3 bytes 255.13kB 0.0%
server/app/[[...path]]/page_client-*.js 3 bytes 255.09kB 0.0%
server/app/platform-*.js 3 bytes 240.32kB 0.0%
static/chunks/main-*.js 53 bytes 2.02kB 2.7%
static/chunks/app/[[...path]]/page-*.js 2 bytes 75.47kB 0.0%
server/middleware-*.js -5.54kB 1.01kB -84.55%
server/middleware-*.js 5.54kB 6.55kB 547.23% ⚠️
static/IXiwiZQRZsJWFVHd1xx-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/IXiwiZQRZsJWFVHd1xx-*.js (New) 581 bytes 581 bytes 100.0% 🚀
static/chunks/8429-*.js (Deleted) -371.26kB 0 bytes -100.0% 🗑️
static/OuXXwFZYCdq1PgwUXEGed/_buildManifest.js (Deleted) -581 bytes 0 bytes -100.0% 🗑️
static/OuXXwFZYCdq1PgwUXEGed/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Files in static/chunks/main-*.js:

  • ./sentry.client.config.ts → Total Size: 1.9kB
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
7517.js -3 bytes 1.66MB -0.0%
../instrumentation.js -3 bytes 910.93kB -0.0%
7688.js -3 bytes 886.9kB -0.0%

Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Lms24 Lms24 merged commit 2bcbe3a into master Mar 28, 2025
13 checks passed
@Lms24 Lms24 deleted the lms/feat-sentry-trace-links-sessionStorage branch March 28, 2025 08:32
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants